fix: stop bundle rewards after close or burn#37
Open
dtopenclaw wants to merge 12 commits intoetherisc:mainfrom
Open
fix: stop bundle rewards after close or burn#37dtopenclaw wants to merge 12 commits intoetherisc:mainfrom
dtopenclaw wants to merge 12 commits intoetherisc:mainfrom
Conversation
…contract Feature/add depeg distribution contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block.timestampwhen a bundle is closedWhy
Issue #31 reports that DIP rewards continue to accumulate after a risk bundle is closed, burned, and later unstaked.
Locally, the bundle registry/staking integration already syncs expiry on bundle creation and lifetime extension, but it did not sync expiry when the bundle lifecycle ends via close/burn. The UI/server reward surface reads bundle registry expiry as the relevant bundle end timestamp, so stale expiry can keep rewards appearing to accrue after the bundle is no longer active.
This patch adds the missing close/burn sync so the effective bundle expiry is clamped to the current time once the bundle is closed.
Validation
Local result:
3 passedCloses #31