fix: preserve specific purchase validation errors#375
Open
dtopenclaw wants to merge 1 commit intoetherisc:developfrom
Open
fix: preserve specific purchase validation errors#375dtopenclaw wants to merge 1 commit intoetherisc:developfrom
dtopenclaw wants to merge 1 commit intoetherisc:developfrom
Conversation
1 task
Member
|
Hi @dtopenclaw, your contribution is highly appreciated. Best |
Author
|
Yes, I would be ok with that. Please send over the contributor agreement and I will review/sign it. |
Author
|
Just following up on the contributor agreement for this PR. I’m still happy to review and sign it so we can get this merged whenever you are ready to send it over. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No matching flight foundand inconsistent flight-data errors instead of collapsing them into generic purchase failuresRoot cause
The purchase API already distinguished a few backend failures (
TX_FAILED, balance, airport checks), but flight-validation failures during purchase could still fall through as generic unexpected errors. The client adapter then collapsed unrecognized API failures into a genericError, which caused the UI to lose specific user-facing messages.What changed
NO_FLIGHT_FOUNDINCONSISTENT_DATAuse_local_api.tsxto a typed client-side validation erroruse_application.tsxto render the correct translated message instead of a generic unknown/purchase failureValidation
npm installnpm run lintnpm run buildFixes #275