send the Eth-Blob-Data-Included header on envelope submission - #150
Open
pk910 wants to merge 1 commit into
Open
Conversation
Beacon nodes on the post-#624 beacon-API spec (e.g. the Lodestar on glamsterdam-devnet-7) reject publishExecutionPayloadEnvelope with 400 "Eth-Blob-Data-Included header is required": the spec renamed the body discriminator from Eth-Execution-Payload-Blinded to Eth-Blob-Data-Included (true = stateless SignedExecutionPayloadEnvelopeContents body). Bump go-eth2-client to a version that sends the new header (keeping the old one for beacon nodes that predate the rename).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reveals on long-running instances against up-to-date beacon nodes (e.g.
buildoor-lodestar-ethrex-1on glamsterdam-devnet-7) fail every attempt with:beacon-APIs#624 renamed the required body-discriminator header on
publishExecutionPayloadEnvelopefromEth-Execution-Payload-BlindedtoEth-Blob-Data-Included(true= statelessSignedExecutionPayloadEnvelopeContentsbody). Lodestar follows the new spec; go-eth2-client v0.1.6 still sent only the old header.This bumps
ethpandaops/go-eth2-clientto a version that sends the new header while keeping the old one for beacon nodes that predate the rename (ethpandaops/go-eth2-client#45), and updates the stale header reference in theSubmitExecutionPayloadEnvelopedoc comment.Testing
go build ./...andgo test ./...pass