Skip to content

fix(server): harden HTTP server timeouts #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samcm wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(server): harden HTTP server timeouts #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a6463
fix(server): harden HTTP server timeouts
samcm Jun 12, 2026
b3c9133
ci(lint): only flag issues introduced by the PR
samcm Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read
pull-requests: read
jobs:
golangci:
name: lint
Expand All @@ -32,7 +32,7 @@ jobs:
# args: --issues-exit-code=0

# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true
only-new-issues: true

# Optional: if set to true then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
Expand Down
8 changes: 6 additions & 2 deletions pkg/checkpointz/checkpointz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ func (s *Server) Start(ctx context.Context) error {

server := &http.Server{
Addr: s.Cfg.GlobalConfig.ListenAddr,
ReadHeaderTimeout: 3 * time.Minute,
WriteTimeout: 15 * time.Minute,
ReadHeaderTimeout: 30 * time.Second,
ReadTimeout: 60 * time.Second,
// Sized for beacon state downloads, which can be hundreds of MB
// and take minutes on slow links.
WriteTimeout: 5 * time.Minute,
IdleTimeout: 120 * time.Second,
}

// Gzip any content longer than 1024 bytes if requested via the Accept-Encoding header
Expand Down
Loading