fix(beacon): guard against nil finality fields and recover request panics - #251
Open
samcm wants to merge 2 commits into
Open
fix(beacon): guard against nil finality fields and recover request panics#251samcm wants to merge 2 commits into
samcm wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an upstream returned a
Finalitywith a nilFinalized,Justified, orPreviousJustified, the majority decider dereferenced it directly and panicked. Because this runs in the background polling goroutine rather than an HTTP handler, that panic took down the process.The decider now skips finality entries with nil fields (they don't count toward the majority threshold),
checkFinalityfilters them before aggregating, and the HTTP router gets aPanicHandlerso a panic on the request path returns a 500 instead of crashing.