devnet-7: lock the agent faucet ingress behind the proxy's basic auth - #55
Merged
Conversation
The agent faucet has no captcha (agents mine via REST), so open ingress meant anyone could claim via the web UI. The htpasswd secret powfaucet-agents-basic-auth (srv credential the panda proxy forwards) is created in the namespace; unauthenticated requests now get 401. Matches what generate_kubernetes_config emits once ingressAuthSecret is set in the collection defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent faucet has no captcha (agents mine via REST), so its open ingress let anyone claim via the web UI. Fixed live already (secret created + ingress annotated — unauth is 401 now); this commits the same annotations so the next ArgoCD sync keeps them. Companion collection change: ethpandaops/ansible-collection-general#570 makes regens emit this. The panda proxy holds the credential, so the authenticated agent path (panda#277) is unaffected.