gloas: fix BeaconState JSON codings for execution_payload_availability and ptc_window - #43
Merged
Merged
Conversation
…y and ptc_window execution_payload_availability is a bitvector, hex-encoded on the wire like justification_bits; it was marshalled as a per-byte decimal array and unmarshalled through encoding/json's base64 path for byte slices, so every gloas BeaconState fetch failed. ptc_window is served by lighthouse as bare JSON numbers rather than the quoted-integer convention; accept both forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two remaining gloas `BeaconState` JSON coding mismatches, found live on glamsterdam-devnet-7 after #42 landed.
Field encodings verified against a live lighthouse `/eth/v2/debug/beacon/states/head` response. Round-trip and lighthouse-shaped tests included.