Fix inverted guard in MarkSkippedNonce so failed nonces are reused - #264
Merged
pk910 merged 1 commit intoJul 30, 2026
Merged
Conversation
MarkSkippedNonce records the nonce of a transaction that failed to submit so the next allocation can reuse it. A failed nonce is always at or above the confirmed count, but the guard returned early for exactly those nonces, so nothing was ever recorded and every failed submit left a gap that the reuse path could not fill. Invert the guard to ignore already-confirmed nonces and keep the pending ones. Add tests for reuse, recording, and ignoring confirmed nonces.
pk910
approved these changes
Jul 30, 2026
pk910
enabled auto-merge
July 30, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarkSkippedNonce records the nonce of a transaction that failed to submit so the next allocation can reuse it. A failed nonce is always at or above the confirmed count, but the guard returned early for exactly those nonces, so nothing was ever recorded and every failed submit left a permanent gap that the reuse path could not fill.
Inverts the guard to ignore already-confirmed nonces and keep the pending ones. Adds tests for reuse, recording, and correctly ignoring confirmed nonces.