Count every processed transaction toward TotalCount - #266
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
RunTransactionScenario only counted a transaction toward TotalCount if it returned an error or had called NotifySubmitted. A scenario that completes successfully without ever calling NotifySubmitted (it may handle its own logging some other way) never advanced the count, so the run kept going past TotalCount instead of stopping at the configured limit. Count every returned call instead. Scenarios that do call NotifySubmitted are unaffected, since those calls were already being counted either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunTransactionScenario only counted a transaction toward TotalCount if it returned an error or had called NotifySubmitted. A scenario that completes successfully without ever calling NotifySubmitted (it may handle its own logging some other way) never advanced the count, so the run kept going past TotalCount instead of stopping at the configured limit. The taskrunner scenario hits this today: its --count flag does not actually bound the run.
Counts every returned call instead. Scenarios that do call NotifySubmitted are unaffected, since those calls were already being counted either way.