Add unique constraints to prevent duplicate rows across dedup tables - #61
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Concurrent identical requests could each pass the check-then-insert dedup logic before either write landed, producing duplicate rows for beacon states, beacon blocks, bad blocks, bad blobs, execution block traces, execution bad blocks, and permanent blocks. Some of these handlers had no dedup check at all. Adds real unique constraints on each table's natural key and treats a constraint violation as the definitive dedup signal instead of a racy prior read. Callers now get a clean AlreadyExists rather than a duplicate row or a leaked database error. Existing databases may already contain duplicates from the race this closes, so migration now removes duplicate rows (keeping the earliest) immediately before each affected table's constraint is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build ./...andgo vet ./...go test ./pkg/server/persistence/...(full suite, no regressions)