Make PermanentStore.Stop wait for in-flight blocks, not just queue drain - #62
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Stop's readiness check watched the queue channel's length, which drops to zero the moment a worker receives a block, not when it finishes processing it. A caller that tore things down right after Stop returned could interrupt a block still mid-copy or mid-write. Track outstanding work with a WaitGroup instead: QueueBlock reserves a slot before a block is admitted, and each worker releases it only after that block is fully processed, success or failure. Stop now blocks on the WaitGroup, still bounded by the caller's context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build ./...andgo vet ./...-raceacross repeated runs