Make FSStore.Delete* return ErrNotFound for missing files - #63
Open
damilolaedwards wants to merge 1 commit into
Open
Make FSStore.Delete* return ErrNotFound for missing files#63damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
Every Delete* method on the filesystem store passed os.Remove's raw error straight through, so a missing file surfaced as an opaque *PathError instead of the package's ErrNotFound sentinel. The S3 backend already made this distinction correctly. The retention watcher relies on errors.Is(err, store.ErrNotFound) to decide whether a missing file is fine to treat as already gone (and still remove the database row) versus a real failure worth retrying. On the filesystem backend that branch could never trigger, so a state whose file was already missing (manual cleanup, a crash mid-delete) could never be purged: retention logged an error and retried forever, leaving the row behind permanently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build ./...andgo vet ./...