Skip to content

Update README.md#74

Open
bkakilli wants to merge 1 commit into
ethz-asl:masterfrom
bkakilli:patch-1
Open

Update README.md#74
bkakilli wants to merge 1 commit into
ethz-asl:masterfrom
bkakilli:patch-1

Conversation

@bkakilli

@bkakilli bkakilli commented Apr 2, 2018

Copy link
Copy Markdown

Fix in the readme for possible missing system packages (eigen, flann) and several required ros packages.

@rdube

rdube commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

@bkakilli thanks for your contribution! Are you sure that all these packages are required? Eg. why ros-kinetic-interactive-markers? Also I would assume that some such as ros-kinetic-tf comes with the default ros install.

Please allow me to leave this PR open until we release the new version (easier not to forget about this when we overwrite).

@bkakilli

bkakilli commented Apr 3, 2018

Copy link
Copy Markdown
Author

Hi @rdube . I specifically don't know where all these packages are used in the code but I installed segmatch onto our desktop and Jetson TX2 (ubuntu 16.04) and in both systems the catkin build process failed until I install those packages.

Also I would assume that some such as ros-kinetic-tf comes with the default ros install.

It must be true for full-ros install, but I had installed ros-kinetic-ros-base, which probably does not carry those robot related packages. A clause such as "desktop or full version of ros is recommended/required" may be enough in your new release, not to create confusion.

@rdube

rdube commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Great thanks for the input!

@rdube rdube closed this Oct 10, 2018
@rdube rdube reopened this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants