NoValue should not throw exception on conversion to bool#64
Open
maximermilov wants to merge 1 commit intoetingof:masterfrom
Open
NoValue should not throw exception on conversion to bool#64maximermilov wants to merge 1 commit intoetingof:masterfrom
maximermilov wants to merge 1 commit intoetingof:masterfrom
Conversation
This improves backward compatibility with 0.1.8
It's really hard to find all occurrences of
if signed_data.getComponentByName('crls'):
...
in large codebase.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=========================================
+ Coverage 83.69% 83.7% +<.01%
=========================================
Files 28 28
Lines 3736 3738 +2
=========================================
+ Hits 3127 3129 +2
Misses 609 609
Continue to review full report at Codecov.
|
Owner
|
Thank you for you PR! I'm not sure about unconditionally ignoring uninitilaized values approach. But your point (to preserve backward compatibility as much as possible while code evolves) is really important! Let me sleep it over, may be I could come up with something that fits the overall design... |
Lostboi
pushed a commit
to inexio/pyasn1
that referenced
this pull request
Dec 21, 2020
droideck
pushed a commit
to hugovk/pyasn1
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves backward compatibility with 0.1.8
It's really hard to find all occurrences similar to
if signed_data.getComponentByName('crls'):
...
in large codebase.