fix: staging package.json version and SW cache error handling#15
Merged
eurobuddha merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
- build-win.sh: switch staging package.json heredoc to unquoted so
${VERSION} expands correctly — was hardcoded 0.4.8, now tracks VERSION
- sw.js: add .catch() to caches.open() in fetch handler so cache quota
errors are logged rather than silently swallowed
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/build-win.sh: stagingpackage.jsonheredoc changed from single-quoted (<< 'PKGJSON') to unquoted (<< PKGJSON) so${VERSION}expands — was hardcoded0.4.8, will now always track the script'sVERSIONvariabletemplate/shop/sw.js:.catch()added tocaches.open()in fetch handler so cache quota or storage errors surface as a console warning instead of being silently swallowedTest plan
npm run build:winand confirm the stagedpackage.jsoncontains"version": "0.5.0"🤖 Generated with Claude Code