fix: status update subject field, pending guard, hoist statusIcons#20
Merged
eurobuddha merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
…Icons - shop/service.js: add subject column to saveMessageToDb INSERT so STATUS_UPDATE (and REPLY) messages saved by the service get their subject stored; without this the buyer inbox list showed raw 'CONFIRMED' instead of 'Order status: Confirmed' when service.js won the race - inbox/app.js: skip sendStatusUpdateToBuyer if pendingStatusUpdateUid is already set — prevents the first pending UID being orphaned when two status updates are sent in quick succession - shop/app.js: hoist statusIcons to module-level STATUS_ICONS constant to avoid the two copies diverging Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shop/service.js:saveMessageToDbwas missing thesubjectcolumn — STATUS_UPDATE messages saved by the service worker showed'CONFIRMED'in the buyer's inbox list instead of'Order status: Confirmed'when the service beat app.js in the save raceinbox/app.js: added guard insendStatusUpdateToBuyerto skip ifpendingStatusUpdateUidis already set, preventing the first pending UID being orphaned when two status updates are sent back-to-backshop/app.js: hoistedstatusIconsto module-levelSTATUS_ICONSconstant — was defined identically inside bothrenderMessageListandrenderMessageDetail🤖 Generated with Claude Code