Skip to content

Commit 3e4ed7d

Browse files
author
Dylan Huang
committed
fix test
1 parent 7590778 commit 3e4ed7d

1 file changed

Lines changed: 16 additions & 6 deletions

File tree

tests/test_logs_server.py

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from eval_protocol.dataset_logger import default_logger
1717
from eval_protocol.dataset_logger.dataset_logger import LOG_EVENT_TYPE
1818
from eval_protocol.event_bus import event_bus
19-
from eval_protocol.models import EvalMetadata, EvaluationRow, InputMetadata, Message
19+
from eval_protocol.models import EvalMetadata, EvaluationRow, InputMetadata, Message, Status
2020
from eval_protocol.utils.logs_server import (
2121
EvaluationWatcher,
2222
LogsServer,
@@ -201,7 +201,9 @@ def test_should_update_status_running_process(self, mock_process):
201201
test_row = EvaluationRow(
202202
messages=[Message(role="user", content="test")],
203203
input_metadata=InputMetadata(row_id="test-123"),
204-
eval_metadata=EvalMetadata(name="test_eval", num_runs=1, aggregation_method="mean", status="running"),
204+
eval_metadata=EvalMetadata(
205+
name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_running()
206+
),
205207
pid=12345,
206208
)
207209

@@ -222,7 +224,9 @@ def test_should_update_status_stopped_process(self, mock_process):
222224
test_row = EvaluationRow(
223225
messages=[Message(role="user", content="test")],
224226
input_metadata=InputMetadata(row_id="test-123"),
225-
eval_metadata=EvalMetadata(name="test_eval", num_runs=1, aggregation_method="mean", status="running"),
227+
eval_metadata=EvalMetadata(
228+
name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_running()
229+
),
226230
pid=12345,
227231
)
228232

@@ -241,7 +245,9 @@ def test_should_update_status_no_such_process(self, mock_process):
241245
test_row = EvaluationRow(
242246
messages=[Message(role="user", content="test")],
243247
input_metadata=InputMetadata(row_id="test-123"),
244-
eval_metadata=EvalMetadata(name="test_eval", num_runs=1, aggregation_method="mean", status="running"),
248+
eval_metadata=EvalMetadata(
249+
name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_running()
250+
),
245251
pid=999,
246252
)
247253

@@ -256,7 +262,9 @@ def test_should_update_status_not_running(self):
256262
test_row = EvaluationRow(
257263
messages=[Message(role="user", content="test")],
258264
input_metadata=InputMetadata(row_id="test-123"),
259-
eval_metadata=EvalMetadata(name="test_eval", num_runs=1, aggregation_method="mean", status="finished"),
265+
eval_metadata=EvalMetadata(
266+
name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_finished()
267+
),
260268
pid=12345,
261269
)
262270

@@ -271,7 +279,9 @@ def test_should_update_status_no_pid(self):
271279
test_row = EvaluationRow(
272280
messages=[Message(role="user", content="test")],
273281
input_metadata=InputMetadata(row_id="test-123"),
274-
eval_metadata=EvalMetadata(name="test_eval", num_runs=1, aggregation_method="mean", status="running"),
282+
eval_metadata=EvalMetadata(
283+
name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_running()
284+
),
275285
pid=None,
276286
)
277287

0 commit comments

Comments
 (0)