-
Notifications
You must be signed in to change notification settings - Fork 16
added model quality gha #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9f6aa7b
added model quality gha
shreymodi1 7d6d905
fixes
shreymodi1 c699532
streaming
shreymodi1 bb743b7
fixes
shreymodi1 275f992
fix
shreymodi1 4315f1e
fix
shreymodi1 fcc7e10
fix
shreymodi1 a1a2046
fix
shreymodi1 cf0ab9d
fix
shreymodi1 67c2619
df
shreymodi1 2900b87
streaming ouput
shreymodi1 406ed5b
changes
shreymodi1 fac4f37
Delete .github/workflows/streaming_compliance.yml
shreymodi1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| name: Streaming Compliance Benchmark | ||
|
|
||
| on: | ||
| push: | ||
| workflow_dispatch: | ||
| inputs: | ||
| model: | ||
| description: "Model id" | ||
| required: true | ||
| default: "fireworks_ai/accounts/fireworks/models/glm-4p6" | ||
| max_tokens: | ||
| description: "Override max_tokens (integer)" | ||
| required: false | ||
| default: "" | ||
| reasoning_effort: | ||
| description: "Reasoning effort (low|medium|high|none)" | ||
| required: false | ||
| default: "" | ||
| max_rows: | ||
| description: "Max rows for smoke vs full run (integer or 'all')" | ||
| required: false | ||
| default: "" | ||
| temperature: | ||
| description: "Temperature (float)" | ||
| required: false | ||
| default: "" | ||
| stream: | ||
| description: "Enable streaming (true or empty)" | ||
| required: false | ||
| default: "true" | ||
| max_concurrency: | ||
| description: "Max concurrency (integer)" | ||
| required: false | ||
| default: "" | ||
| num_runs: | ||
| description: "Number of runs (integer)" | ||
| required: false | ||
| default: "" | ||
| max_retry: | ||
| description: "Max retry (integer)" | ||
| required: false | ||
| default: "" | ||
| success_threshold: | ||
| description: "Minimum test score needed to pass (float)" | ||
| required: false | ||
| default: "" | ||
|
|
||
| jobs: | ||
| streaming-compliance: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 180 | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Setup uv and .venv | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install uv | ||
| uv venv | ||
| . .venv/bin/activate | ||
| uv pip install --upgrade pip | ||
|
|
||
| - name: Install python-sdk package | ||
| run: | | ||
| . .venv/bin/activate | ||
| uv pip install . | ||
|
|
||
| - name: Run streaming compliance benchmark (pytest) | ||
| env: | ||
| FIREWORKS_API_KEY: ${{ secrets.FIREWORKS_API_KEY }} | ||
| FIREWORKS_ACCOUNT_ID: ${{ vars.FIREWORKS_ACCOUNT_ID }} | ||
| run: | | ||
| . .venv/bin/activate | ||
| mkdir -p artifacts | ||
|
|
||
| MODEL="${{ github.event.inputs.model }}" | ||
| MAX_TOKENS="${{ github.event.inputs.max_tokens }}" | ||
| REASONING="${{ github.event.inputs.reasoning_effort }}" | ||
| MAX_ROWS="${{ github.event.inputs.max_rows }}" | ||
| TEMPERATURE="${{ github.event.inputs.temperature }}" | ||
| STREAM="${{ github.event.inputs.stream }}" | ||
| NUM_RUNS="${{ github.event.inputs.num_runs }}" | ||
| MAX_CONC="${{ github.event.inputs.max_concurrency }}" | ||
| MAX_RETRY="${{ github.event.inputs.max_retry }}" | ||
| SUCCESS_THRESHOLD="${{ github.event.inputs.success_threshold }}" | ||
|
|
||
| echo "Running streaming compliance with reasoning_effort=${REASONING:-<default>} max_rows=${MAX_ROWS:-<default>} model=${MODEL:-<default>} max_tokens=${MAX_TOKENS:-<default>} temperature=${TEMPERATURE:-<default>} stream=${STREAM:-<default>} num_runs=${NUM_RUNS:-<default>} max_concurrency=${MAX_CONC:-<default>} max_retry=${MAX_RETRY:-<default>} success_threshold=${SUCCESS_THRESHOLD:-<default>}" | ||
|
|
||
| PYTEST_TARGET=eval_protocol.benchmarks.test_glm_streaming_compliance | ||
| PYTEST_ARGS="--pyargs $PYTEST_TARGET -q -s --ep-print-summary --ep-summary-json artifacts/streaming_compliance.json" | ||
| [ -n "$MAX_ROWS" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-max-rows=$MAX_ROWS" | ||
| [ -n "$REASONING" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-reasoning-effort=$REASONING" | ||
| [ -n "$MODEL" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-input-param model=$MODEL" | ||
| [ -n "$MAX_TOKENS" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-input-param max_tokens=$MAX_TOKENS" | ||
| [ -n "$TEMPERATURE" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-input-param temperature=$TEMPERATURE" | ||
| [ -n "$STREAM" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-input-param stream=$STREAM" | ||
| [ -n "$NUM_RUNS" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-num-runs=$NUM_RUNS" | ||
| [ -n "$MAX_CONC" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-max-concurrent-rollouts=$MAX_CONC" | ||
| [ -n "$MAX_RETRY" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-max-retry=$MAX_RETRY" | ||
| [ -n "$SUCCESS_THRESHOLD" ] && PYTEST_ARGS="$PYTEST_ARGS --ep-success-threshold=$SUCCESS_THRESHOLD" | ||
| echo "Running: pytest $PYTEST_ARGS" | ||
| pytest $PYTEST_ARGS | ||
|
|
||
| - name: Upload JSON artifact(s) | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: streaming_compliance_json | ||
| path: artifacts/*.json | ||
| if-no-files-found: warn | ||
| retention-days: 14 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unrestricted Push Triggers Cause Excess CI Runs
The workflow trigger
on: push:without branch filters will run on every push to any branch, including feature branches and pull requests. This causes unnecessary CI runs and resource consumption. Other workflows in the repository likeci.ymlandfireworks-tracing-tests.ymlrestrict pushes to specific branches (e.g.,main) or use path filters to avoid this issue.