Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Touches core CLI argument registration logic, so mistakes could break command parsing across multiple commands, but the change is small and covered by new regression tests.
Overview
Prevents
add_args_from_callable_signaturefrom registering conflicting option strings by reserving canonical flags up front and only adding alias/shorthand flags when they don’t collide with existing options or other canonical flags.Adds regression tests ensuring duplicate nested shorthand flags are skipped and that a later top-level canonical flag cannot be “stolen” by an earlier nested shorthand alias. Separately, makes the Hugging Face adapter E2E test skip on common upstream network failures to reduce flakiness.
Written by Cursor Bugbot for commit 9268956. This will update automatically on new commits. Configure here.