Merged
Conversation
gertjanvanzwieten
changed the title
This patch replaces StringIO by string join to generate the script in evaluable.compile.
gertjanvanzwieten
force-pushed
the
function
branch
2 times, most recently
from
95e7241 to
8b9130f
Compare
This patch introduces _util.function to replace the compilation code from evaluable.compile.
gertjanvanzwieten
force-pushed
the
function
branch
from
8b9130f to
0807f9a
Compare
gertjanvanzwieten
force-pushed
the
function
branch
2 times, most recently
from
7a2a0d2 to
05fcdab
Compare
In evaluable.compile, this patch replaces the single lock for all shared data by a fine grained set of individual locks to reduce waiting times at high processor counts.
This patch removes the lock around assignments, which are unnecessary by
definition, to remove some overhead associated with aqcuiring the lock. The
generated code changes as follows.
Before:
# LoopSum e0; alloc
with lock0:
v0 = parallel.shempty((), dtype=float)
After:
# LoopSum e0; alloc
v0 = parallel.shempty((), dtype=float)
gertjanvanzwieten
force-pushed
the
function
branch
from
05fcdab to
95cc2f7
Compare
joostvanzwieten
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.