Fix memory leak in checkpoint drop - #15
Draft
evanlinjin wants to merge 1 commit into
Draft
Conversation
evanlinjin
force-pushed
the
codex/locate-and-fix-an-important-bug
branch
from
July 19, 2025 07:36
e4a9ab9 to
f3b9dd3
Compare
Fix memory leak bug in `CheckPoint::drop` by using `Arc::into_inner` if it is available (>= 1.70). Fix `CPInner::drop` logic so that if `CPInner::block` becomes generic and is of a type that required `drop`, it does not leak memory. Add tests for memory leak + stack overflow when dropping `CheckPoint`.
evanlinjin
force-pushed
the
codex/locate-and-fix-an-important-bug
branch
from
July 20, 2025 06:17
f3b9dd3 to
bf417f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo clippy -p bdk_core -- -D warningscargo test -p bdk_core -- --test-threads=1https://chatgpt.com/codex/tasks/task_e_687b0cee4bec832db8c6c604e4100a6e