Skip to content

Fix team-status dropdown spurious self-close on dispatch board #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanqua merged 1 commit into from
Jul 9, 2026
Merged

Fix team-status dropdown spurious self-close on dispatch board #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/components/dispatch/calltracking.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@ export const CallTrackingTable: React.FC<CallTrackingTableProps> = ({
const [closingCallId, setClosingCallId] = React.useState<string | null>(null);
const [openMenuToken, setOpenMenuToken] = React.useState<string | null>(null);
const previousOpenCallIdRef = React.useRef<string | null>(null);
// HeroUI/react-aria's Popover can spuriously fire onOpenChange(false) a few
// milliseconds after opening, with no user interaction (a known upstream
// focus/blur-tracking race — see adobe/react-spectrum#4533). Real users
// never dismiss a menu that fast, so ignore closes inside this window
// unless they came from an actual selection (onAction).
const TEAM_STATUS_MENU_CLOSE_GUARD_MS = 150;
const teamStatusMenuOpenedAtRef = React.useRef<number>(0);
const teamStatusMenuSelectedRef = React.useRef<boolean>(false);
const {
notesTexts,
setNotesTexts,
Expand Down Expand Up @@ -437,9 +445,15 @@ export const CallTrackingTable: React.FC<CallTrackingTableProps> = ({
onOpenChange={(isOpen) => {
if (isOpen) {
if (isResolvedCall && !showResolvedCalls) return;
teamStatusMenuOpenedAtRef.current = Date.now();
setOpenMenuToken(`team-status:${call.id}:${team}`);
return;
}
const selected = teamStatusMenuSelectedRef.current;
teamStatusMenuSelectedRef.current = false;
if (!selected && Date.now() - teamStatusMenuOpenedAtRef.current < TEAM_STATUS_MENU_CLOSE_GUARD_MS) {
return;
}
setOpenMenuToken((current) =>
current === `team-status:${call.id}:${team}` ? null : current
);
Expand All @@ -456,7 +470,10 @@ export const CallTrackingTable: React.FC<CallTrackingTableProps> = ({
</DropdownTrigger>
<DropdownMenu
aria-label="Team status"
onAction={(key) => handleTeamStatusChange(call.id, team, key as string)}
onAction={(key) => {
teamStatusMenuSelectedRef.current = true;
handleTeamStatusChange(call.id, team, key as string);
}}
>
{statusOptions.map((status: string) => (
<DropdownItem key={status}>{status}</DropdownItem>
Expand Down
Loading