Skip to content

Conversation

@rasmus
Copy link
Member

@rasmus rasmus commented Oct 11, 2025

Moving the old EventStore code to https://www.kurrent.io/

@rasmus
Copy link
Member Author

rasmus commented Oct 25, 2025

.review

@github-actions
Copy link

Findings

  • Source/EventFlow.Kurrent.Tests/IntegrationTests/KurrentEventStoreTests.cs:39 (High) – The override of Options(...) no longer calls the base implementation from TestSuiteForEventStore. That base method injects the ISubscribeSynchronousToAll mock which the suite relies on for assertions about published domain events. Without it, every test that inspects PublishedDomainEvents will fail. Call base.Options(eventFlowOptions) (and then append the Kurrent-specific wiring) to keep the subscriber registered.
  • Source/EventFlow.Kurrent/EventFlow.Kurrent.csproj:3 (High) – The replacement for EventFlow.EventStores.EventStore now targets only net8.0, whereas the old package shipped as netstandard2.0. This drops support for the existing EventFlow hosting story on netcoreapp3.1/net6.0 and earlier, so anybody not yet on net8 can no longer use an EventStore-compatible backend. Please multi-target (or document/communicate a deliberate breaking change and bump accordingly) so the new package remains usable for the same consumer set.

@github-actions
Copy link

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been
no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still
think this pull request is necessary or relevant, please feel free to update it or leave a
comment within the next seven days.

Thank you for your contributions and understanding.

Best regards,
EventFlow

@github-actions github-actions bot added the stale label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants