Skip to content

fix: streamline animated image playback flow#597

Merged
everpcpc merged 2 commits intomainfrom
codex/animated-playback-simplify
Mar 2, 2026
Merged

fix: streamline animated image playback flow#597
everpcpc merged 2 commits intomainfrom
codex/animated-playback-simplify

Conversation

@everpcpc
Copy link
Owner

@everpcpc everpcpc commented Mar 2, 2026

Summary

  • Restrict animated playback preparation to the currently focused view item (including dual-page pairs) and cancel stale prepare/transcode tasks as soon as focus changes.
  • Simplify animated transcoding by removing serial slot scheduling, timeout handling, and low-priority execution while keeping actor-based task deduplication/cancellation.
  • Remove the InlineAnimatedImageView wrapper and render animated playback directly via LoopingVideoPlayerView.
  • Align cover/scroll/pagecurl/native animated playback paths so page turns consistently trigger preparation and playback rendering.

Testing

  • Please run make build
  • Manual reader regression for cover/scroll/pagecurl + dual-page animated playback

everpcpc added 2 commits March 2, 2026 22:20
Restrict animated playback preparation to the currently focused view item, including dual-page pairs, and cancel stale preparation/transcode tasks immediately on focus changes.

Simplify the transcoder by dropping serial slot scheduling and timeout handling while keeping actor-backed task de-duplication and cancellation.

Remove InlineAnimatedImageView and wire ReaderViewItemImageView directly to LoopingVideoPlayerView, plus align cover/scroll/pagecurl/native paths so animated pages render consistently after page turns.
@everpcpc everpcpc merged commit 3b9fadd into main Mar 2, 2026
3 checks passed
@everpcpc everpcpc deleted the codex/animated-playback-simplify branch March 2, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant