fix: upside-down offline PDF DIVINA render and show progress#601
Merged
fix: upside-down offline PDF DIVINA render and show progress#601
Conversation
Use non-flipped PDF page rendering transforms for offline DIVINA PNG generation so cached pages are not upside down. Add progress reporting from PDF offline preparation to ReaderViewModel and show determinate progress in DivinaReaderView while rendering. Bump offline PDF preparation stamp version to force one-time regeneration of previously cached upside-down renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make build-macosmake build-iosmake build-tvosCloses #600