fix(js): correct sqlite maxMemory unit handling#1609
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 8f46d36 | Commit Preview URL | May 08 2026, 07:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
maxMemory(documented and used as bytes) was treated as MiB when derivingSqliteLimits, inflatingmax_db_bytesand weakening host memory controls.Description
derive_sqlite_limitsusestate.max_memoryas bytes by renaming the local tomemory_bytesand removing the* 1024 * 1024multiplication somax_db_bytesis computed asmemory_bytes.max(0.0).floor() as usize.Testing
cargo fmt --allwhich completed successfully andcargo check -p bashkit-jswhich finished successfully.Codex Task