fix(shuf): cap range and repeat output allocation#1612
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 0616dab | Commit Preview URL | May 08 2026, 08:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
shufso attacker-controlled numeric ranges and repeat counts cannot force unbounded in-process allocation.Why
shuf -i LO-HI -n Nmaterialized the full range before applying-n, andshuf -r -n Ncollected all repeated output before interpreter stdout truncation. Hugeu64inputs could exhaust CPU or memory.How
ExecutionLimitsbefore allocation.-n 1and repeat output caps.TM-DOS-090.Risk
shufnow returns an explicit error when requested output exceeds the execution output limit instead of relying on post-command truncation.Checklist
Validation:
cargo fmt --checkCARGO_INCREMENTAL=0 cargo clippy --all-targets -- -D warningsCARGO_INCREMENTAL=0 cargo testCARGO_INCREMENTAL=0 just vet-n 1returns one lineoutput too large