fix(printf): cap float exponent magnitude in format validation#1618
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 275bebd | Commit Preview URL | May 09 2026, 12:26 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
printfpath can parse floats into arbitrary-precisionBigDecimaland then materialize a fixed-decimalString, letting tiny inputs like1e1000000000cause enormous allocations because preflight validation only checked width/precision.Description
CapSpecwith aspecifierfield and detect float-style specifiers viais_float_specifierto run float-specific checks while keeping existing width/precision caps.reject_float_exponent_over_capwhich peeks the raw argument, usesparse_float_exponent+parse_leading_i64to extract an exponent, and rejects it if its magnitude exceedsMAX_FORMAT_WIDTH.args.consumebehaviour.rejects_float_exponent_over_capassertingrender_printf("%f", &["1e1000000000".into()])fails quickly with a cap error.Testing
cargo test -p bashkit rejects_float_exponent_over_cap -- --nocaptureand the new test passed (ok).Codex Task