feat: improve telemetry and use a more suitable tool than google-analytics#147
Draft
warlof wants to merge 2 commits intoeveseat:masterfrom
Draft
feat: improve telemetry and use a more suitable tool than google-analytics#147warlof wants to merge 2 commits intoeveseat:masterfrom
warlof wants to merge 2 commits intoeveseat:masterfrom
Conversation
src/Traits/Telemeter.php
Outdated
|
|
||
| // Generate a V4 random UUID | ||
| // https://gist.github.com/dahnielson/508447#file-uuid-php-L74 | ||
| $id = sprintf('%04x%04x-%04x-%04x-%04x-%04x%04x%04x', |
There was a problem hiding this comment.
Why not use Str::uuid() ?
warlof
force-pushed
the
influxdb-telemetry
branch
from
6cb1a03 to
971b7af
Compare
…tics telemetry is still an optional thing and can be disabled into settings the list of collected data is the following : - instance unique ID - amount of valid refresh tokens - amount of character sheet - amount of corporation sheet - used php version - used operating system - installed SeAT packages and related versions - called endpoint mask and http response status
as per @eugenebednik, use Laravel Str facade to compute a valid instance ID
warlof
force-pushed
the
influxdb-telemetry
branch
from
971b7af to
6db2536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
telemetry is still an optional thing and can be disabled into settings
the list of collected data is the following :
Used in scheduled commands, those information can help to determine :