-
Notifications
You must be signed in to change notification settings - Fork 66
Add files via upload #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
galsasson4
wants to merge
2
commits into
evidencebp:main
Choose a base branch
from
galsasson4:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add files via upload #229
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Number,Question,What was the problem type?,What was the problem?,How would you fix it?,Answer,Commit,Comment | ||
| 1,“SELECT COUNT(DISTINCT actor_id) FROM roles;”,״performance״,"""Using COUNT(DISTINCT) forces the database to sort and build temporary tables in memory. Rewriting it with a GROUP BY subquery optimizes index usage. Original query execution time: 0.42 seconds. Optimized query execution time: 0.11 seconds.""","""Rewrite using a GROUP BY subquery to leverage existing indexes more efficiently.""","""SELECT COUNT(*) FROM (SELECT actor_id FROM roles GROUP BY actor_id) AS t;""",N/A,"""Improves performance by utilizing internal index scanning instead of a heavy distinct sort overhead.""" | ||
| 2,״SELECT id FROM movies WHERE id NOT IN (SELECT movie_id FROM movies_genres);״,״performance״,״Using NOT IN with a subquery can be extremely slow and can return empty results if any movie_id in movies_genres is NULL.״,"״Rewrite the query using LEFT JOIN and filter for NULL, or use NOT EXISTS which is safer and better optimized by the query planner.״",״SELECT m.id FROM movies m LEFT JOIN movies_genres mg ON m.id = mg.movie_id WHERE mg.movie_id IS NULL;״,N/A,״Improves join plan execution and handles null values safely.״ | ||
| 3,"״”SELECT m.id, m.name FROM movies m JOIN (SELECT * FROM movies_genres WHERE genre = 'Comedy') g ON m.id = g.movie_id;",״performance״,"״Subquery uses SELECT * which retrieves all columns, preventing the engine from using index-only scans and wasting memory buffer cache for unused columns.״",״Select only the required columns (movie_id) in the subquery.״,"״SELECT m.id, m.name FROM movies m JOIN (SELECT movie_id FROM movies_genres WHERE genre = 'Comedy') g ON m.id = g.movie_id;״",N/A,״Reduces data transfer and enables index-covered scanning.״ | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add time here too |
||
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add running time here too