Skip to content

fix: sort labels by str() key to handle mixed int/str label types #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YousefZahran1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sort labels by str() key to handle mixed int/str label types #1872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/evidently/legacy/calculations/classification_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,10 @@ def calculate_lift_table(binded):


def calculate_matrix(target: pd.Series, prediction: pd.Series, labels: List[Label]) -> ConfusionMatrix:
sorted_labels = sorted(labels) # type: ignore[type-var]
# Use str() as sort key to avoid TypeError when labels contain mixed int/str types.
# This happens when string labels like '101' are coerced to int by label_key_valudator
# while other labels (e.g. 'foo') remain as strings.
sorted_labels = sorted(labels, key=str)
matrix = metrics.confusion_matrix(target, prediction, labels=sorted_labels)
return ConfusionMatrix(labels=sorted_labels, values=[row.tolist() for row in matrix])

Expand Down