Fix path traversal in FSLocation storage operations#1891
Open
Code-ve wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces path containment validation for filesystem-backed storage operations in
FSLocation.Previously, paths were resolved using
posixpath.join()without verifying that the resulting path remained within the configured storage root. This allowed path traversal sequences (../) and absolute paths to resolve outside the intended workspace boundary.Changes
_safe_path()helper to normalize and validate paths before they are used in filesystem operations.open,makedirs,listdir,isdir,exists,rmtree,invalidate_cache, andsizeto use the validated path resolution logic.Tests
Added regression tests covering:
../).The implementation follows the containment-based remediation approach discussed in the issue and preserves the existing storage interface while preventing access outside the configured filesystem boundary.