Update simpleclient to 0.9.0 - #96
Conversation
📝 WalkthroughWalkthroughThe Prometheus ChangesPrometheus dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@project/Dependencies.scala`:
- Around line 24-26: Update the Prometheus dependency declared by simpleclient
to use the intended io.prometheus:simpleclient version 0.16.0. Remove the 0.9.0
fork-specific version assumption unless the dependency is instead changed to an
explicit fork coordinate with its resolver configuration; do not rely on
publishTo for dependency resolution.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4c66ce4b-aa2d-4c7e-ab67-97b82518b9c4
📒 Files selected for processing (1)
project/Dependencies.scala
| // fixing the prometheus version in place because we use a 0.9.0 fork internally | ||
| private val version = "0.9.0" // scala-steward:off | ||
| val simpleclient = "io.prometheus" % "simpleclient" % version |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 5 \
'simpleclient|scala-steward:off|dependencyOverrides|resolvers|Resolver|credentials|0\.8\.1|0\.9\.0|0\.16\.0' \
project/Dependencies.scala build.sbt instrumentation || trueRepository: evolution-gaming/akka-tools
Length of output: 1894
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- candidate build files ---'
git ls-files | rg '(^|/)(build\.sbt|Dependencies\.scala|.*\.sbt|.*\.scala)$' | head -200
printf '%s\n' '--- dependency and resolver references ---'
rg -n -C 4 \
'evolutionReleases|simpleclient|Prometheus|dependencyOverrides|resolvers\s*:|Resolver\.|credentials|ivyPatterns|maven' \
--glob '*.sbt' --glob '*.scala' --glob '*.conf' --glob '*.md' . | head -400Repository: evolution-gaming/akka-tools
Length of output: 5028
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- project/plugins.sbt ---'
cat -n project/plugins.sbt
printf '%s\n' '--- build.sbt ---'
cat -n build.sbt
printf '%s\n' '--- project/Dependencies.scala ---'
cat -n project/Dependencies.scala
printf '%s\n' '--- repository and fork references ---'
rg -n -i -C 4 \
'prometheus|simpleclient|fork|evolutionreleases|resolver|repository|override' \
--glob '!target/**' --glob '!node_modules/**' .Repository: evolution-gaming/akka-tools
Length of output: 37878
Use the intended Prometheus artifact and version.
The PR target is io.prometheus:simpleclient:0.16.0. The repository has no dependency resolver or override that maps io.prometheus:simpleclient:0.9.0 to an internal fork; publishTo := Some(Resolver.evolutionReleases) only controls publishing. Set the version to 0.16.0, or declare the fork coordinate and resolver explicitly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@project/Dependencies.scala` around lines 24 - 26, Update the Prometheus
dependency declared by simpleclient to use the intended
io.prometheus:simpleclient version 0.16.0. Remove the 0.9.0 fork-specific
version assumption unless the dependency is instead changed to an explicit fork
coordinate with its resolver configuration; do not rely on publishTo for
dependency resolution.




Updates io.prometheus:simpleclient from 0.8.1 to 0.16.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
labels: library-update, early-semver-major, semver-spec-minor, commit-count:1
Summary by CodeRabbit