Add optional SonarQube Cloud scan - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sonar,sonar_project_keyandsonar_argsinputs. Scans once, on the first Scala version only, since SonarQube tracks one analysis per branch. Config is passed as scanner arguments, so no per-repo sonar-project.properties is needed.Off by default, because three prerequisites are unmet:
SONAR_TOKENorganization secret exists. Enabling it before that will fail.Context: the Sonar app currently creates a check suite on every commit in repos it never analyses, leaving a permanently queued check with no result (cats-helper, scache, sstream, kafka-flow).
skafkaandscassandrareport fine with no repo config at all, so this was never a missing-file problem.