Skip to content

add handling for clean vs cleanFull, update capitalization of some names - #8

Merged
mr-git merged 1 commit into
mainfrom
m/updates
Aug 10, 2026
Merged

add handling for clean vs cleanFull, update capitalization of some names#8
mr-git merged 1 commit into
mainfrom
m/updates

Conversation

@mr-git

@mr-git mr-git commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added an optional workflow input to override the sbt clean task.
    • Improved compatibility by selecting the appropriate clean command based on the sbt version when no override is provided.
  • Documentation

    • Improved README wording, capitalization, hyphenation, and table formatting.
    • Clarified workflow input and ordering descriptions.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c6e7bae7-6315-4bff-80e7-d376df9b3594

📥 Commits

Reviewing files that changed from the base of the PR and between 7991c63 and 54b7299.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • README.md

📝 Walkthrough

Walkthrough

The reusable CI workflow adds configurable sbt clean-task selection. It chooses cleanFull for sbt 2 and clean otherwise when no override is provided. Build commands use the resolved task. The README and workflow descriptions receive wording and formatting corrections.

Changes

CI clean-task configuration

Layer / File(s) Summary
Workflow task resolution
.github/workflows/ci.yml
Adds the clean_task input, resolves the clean task from the override or sbt major version, renames the test-task step, and updates build commands.
Workflow documentation
README.md
Corrects capitalization and hyphenation, aligns the Inputs table, and updates workflow-ordering terms.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: stasimus

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch m/updates

Comment @coderabbitai help to get the list of available commands.

@mr-git
mr-git merged commit dde27b9 into main Aug 10, 2026
1 of 2 checks passed
@mr-git
mr-git deleted the m/updates branch August 10, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant