Skip to content

Add KafkaMetricsRegistry - #243

Open
Z1kkurat wants to merge 2 commits into
masterfrom
kafka-native-metrics
Open

Add KafkaMetricsRegistry#243
Z1kkurat wants to merge 2 commits into
masterfrom
kafka-native-metrics

Conversation

@Z1kkurat

Copy link
Copy Markdown
Contributor

This issue addresses #237.

Please read the updated README.md, it contains the reasoning behind the change and a full (I hope) description of the new API.

Let me know what you think about it.

@t3hnar

t3hnar commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

hm, are we sure it should be module of smetrics and not skafka ?

@Z1kkurat

Z1kkurat commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

hm, are we sure it should be module of smetrics and not skafka ?

@t3hnar This is a good question. On the one hand, I agree that this code doesn't depend on anything from smetrics and could be placed in skafka. On the other hand, the whole essence of it is collecting metrics, I don't think it makes much sense without having KafkaMetricsCollector to expose the collected metrics and it was created to overcome the limitations of KafkaMetricsCollector (being a Prometheus collector).

But I like the idea of moving it to skafka. I'll start working on it.

@Z1kkurat

Z1kkurat commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

@t3hnar thanks for the idea, PR to skafka with the identical content: evolution-gaming/skafka#324

@stasimus

stasimus commented Aug 1, 2026

Copy link
Copy Markdown

@Z1kkurat should we keep this PR?

@stasimus stasimus closed this Aug 4, 2026
@stasimus stasimus reopened this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants