2to3 conversion, manual sync of fixes from upstream egh/spydaap#6
2to3 conversion, manual sync of fixes from upstream egh/spydaap#6Saijin-Naib wants to merge 1 commit intoexaile:masterfrom
Conversation
|
You might want to try to use and enforce type hinting. This looks very wrong to me, but unrelated to logging. Why would the length ever be a float? I'd recommend investigating the parsers |
|
I am unsure about the existing functions. I ran 2to3 with python 3.12.x and made some basic fixes to names/imports it missed, but anything beyond is above me at the moment. |
|
We have a Back then I was testing exaile's DAAP client and I recall it was working. That doesn't seem to be the case anymore, though - while exaile's DAAP plugin successfully retrieves the tracks, it doesn't add them to collection because they seem to fail the |
I've gotten it about as far as I can figure at this point, but I think the logging function needs a rework to work properly under Python3:
Hopefully this is somewhat helpful as a starting point to carry forward fixing up spydaap for Python3, and thus Exaile 4.x usage.