Use Adapt.jl for backend array conversion#236
Conversation
|
The MacOS test is failing because |
|
@sshin23 Previously, the macOS runner was set to
I added a macOS runner set to |
0547a3a to
4f493ce
Compare
|
Myea, Metal doesn't support Float64 😕. |
|
I gave metal support a shot a while ago. I don't think it's complete but maybe it can be useful for you: main...klamike:ExaModels.jl:mk/metal |
4f493ce to
e7c3d73
Compare
I've reverted now in this PR. Using Metal should work out of the box, but to get the tests working with Float32 seems hard. |
|
We have some |
|
Nice! Yeah looks like most of those changes were just casting to Float32 all over the place. |
|
I wonder what the benefit of |
ExaModels.convert_array(v, backend) = KernelAbstractions.allocate(backend, eltype(v), length(v))
Adapt is a dependency of all GPU packages and KA. It's a very light package that basically defines an API. |
|
Great. Thank you, @michel2323! |
|
Maybe waiting for this JuliaGPU/OpenCL.jl#423 so we can remove OpenCL too. |
|
The OpenCL PR takes too long. Merging. |
@sshin23 , This is equivalent to #235, but uses
Adapt.