Test diagonal and upper triangular matrix coefficients in pressureVelocityCoupling test#275
Merged
Conversation
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_275 |
greole
commented
Apr 26, 2026
| ofUEqn.upper(), | ||
| ApproxVector(1e-15) | ||
| ); | ||
| nf::compare(nfUEqn.linearSystem().matrix().diag(), ofUEqn.diag(), ApproxVector(1e-15)); |
Contributor
Author
There was a problem hiding this comment.
@HenningScheufler, @HendriceH any idea why this test fails?
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Ok, I guess I was stupid and we discussed this several times already, but just for reference: we include the boundary contributions to the diagonal elements in the Laplacian and div kernel already (Kokkos::atomic_sub(&values[rowOwnStart + diagOffs[own]], valueMat); ), but OpenFOAM doesn't.
greole
force-pushed
the
fix/failingDiagTest
branch
from
9eb32e8 to
df62c18
Compare
greole
changed the title
greole
changed the title
greole
force-pushed
the
fix/failingDiagTest
branch
from
a185016 to
7ec5228
Compare
chihtaw
approved these changes
May 13, 2026
| nf::compare( | ||
| NeoN::la::upper(nfUEqn.linearSystem().matrix()), | ||
| ofUEqn.upper(), | ||
| ApproxVector(1e-15) |
Collaborator
There was a problem hiding this comment.
The current tolerance may be overly strict on GPU backends.
This is probably fine on CPU/deterministic runs, but may become fragile on GPU. Consider something closer to 1e-12.
Co-authored-by: Chih-Ta Wang <97195768+chihtaw@users.noreply.github.com>
greole
force-pushed
the
fix/failingDiagTest
branch
from
386136c to
42d2063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart to exasim-project/NeoN#495 and adds a test to the pressureVelocityCoupling tests to ensure the correctness of the diagonal and upper triangular matrix coefficients.
Additionally: