Skip to content

Add github actions for image building & support for nginx proxy configuration in env variable#7

Open
starsoccer wants to merge 2 commits into
excaliburpartners:devfrom
starsoccer:dev
Open

Add github actions for image building & support for nginx proxy configuration in env variable#7
starsoccer wants to merge 2 commits into
excaliburpartners:devfrom
starsoccer:dev

Conversation

@starsoccer

Copy link
Copy Markdown

So this adds github actions that auto publishes 2 images for each change one for the proxy, and one for the mono app. The one caveat and we make way to tweak this is that the branch name is used for all tags so master branch will produce an image called master and then master-proxy

On top of this I also added the ability to set the proxy pass location. I am not sure how widely used this will be but currently I am running both containers on unraid outside docker compose and internal routing by container name does not work. So this just gives some more flexibility

@CLAassistant

CLAassistant commented Sep 13, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@starsoccer starsoccer mentioned this pull request Sep 13, 2023
@starsoccer

Copy link
Copy Markdown
Author

Just force pushed some changes just amending the commits to hopefully match up to my github user per the above CLA Assistant

@starsoccer

Copy link
Copy Markdown
Author

@rwagoner Any word on getting this PR merged?

@starsoccer

Copy link
Copy Markdown
Author

@rwagoner Bump again on getting this merged? Id rather have a single repo be the source of truth and not have to fork and make my own version and keep maintaining things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants