Add github actions for image building & support for nginx proxy configuration in env variable#7
Open
starsoccer wants to merge 2 commits into
Open
Add github actions for image building & support for nginx proxy configuration in env variable#7starsoccer wants to merge 2 commits into
starsoccer wants to merge 2 commits into
Conversation
Open
Author
|
Just force pushed some changes just amending the commits to hopefully match up to my github user per the above CLA Assistant |
Author
|
@rwagoner Any word on getting this PR merged? |
Author
|
@rwagoner Bump again on getting this merged? Id rather have a single repo be the source of truth and not have to fork and make my own version and keep maintaining things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this adds github actions that auto publishes 2 images for each change one for the proxy, and one for the mono app. The one caveat and we make way to tweak this is that the branch name is used for all tags so master branch will produce an image called
masterand thenmaster-proxyOn top of this I also added the ability to set the proxy pass location. I am not sure how widely used this will be but currently I am running both containers on unraid outside docker compose and internal routing by container name does not work. So this just gives some more flexibility