Fix FastMCP constructor for current mcp versions and remove PyPI install instructions#11
Open
bmoeskau wants to merge 2 commits into
Open
Fix FastMCP constructor for current mcp versions and remove PyPI install instructions#11bmoeskau wants to merge 2 commits into
bmoeskau wants to merge 2 commits into
Conversation
description= and version= were removed from FastMCP.__init__(); the modern equivalent is instructions=, with version read from the mcp package metadata. Without this, the server crashes on import.
This fork is not published to PyPI. The pip install things-mcp instructions resolve to the unrelated upstream hald/things-mcp package. Removing Option 1 until/unless this fork is published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes that together get the server running again from a fresh clone:
FastMCP(...)constructor crash on startup. Withmcp >= ~1.10,FastMCP.__init__()no longer acceptsdescription=orversion=kwargs, so the server crashes on import:Replaced with the modern
instructions=parameter;versionis now read automatically from the installedmcppackage metadata.README points at a PyPI package that doesn't publish this fork. "Option 1: Install from PyPI" tells users to
pip install things-mcp, but that name resolves to the upstreamhald/things-mcppackage on PyPI — not this fork — so users following the README either get the wrong code or (per PyPi project 'mcp-things' does not exist #7) hit a name that doesn't exist at all. Removed Option 1 entirely and promoted "Manual Installation" as the single supported path until/unless this fork is published.Test plan
uv venv && uv pip install -e .+ runthings_fast_server.py— server starts and responds to a JSON-RPCinitializerequestget-inboxandget-todaytools return data from a live Things 3 installCloses #7.