Add ability to change exercise-title and solution-title from conf.py …#74
Closed
yguel wants to merge 0 commit intoexecutablebooks:mainfrom
Closed
Add ability to change exercise-title and solution-title from conf.py …#74yguel wants to merge 0 commit intoexecutablebooks:mainfrom
yguel wants to merge 0 commit intoexecutablebooks:mainfrom
Conversation
Member
Author
|
@mmcky no problem for the delay, I know what it is to maintain a tool ... your changes work nicely for me, and that PR can be closed. For the record, I have archived my PR in the branch i18n_attempt00 in my fork. However there is still a big problem to fix for translations: the subtitle is not available in the po files as a string that can be translated. I will work on that to propose a new PR based on your work to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and open i18n for those titles.
I made really small changes and it works very well on my tests.
Could you consider the changes for merge ?