Skip to content

Feature/embedded editor#24

Open
erseco wants to merge 19 commits intoexelearning:mainfrom
ateeducacion:feature/embedded-static-editor
Open

Feature/embedded editor#24
erseco wants to merge 19 commits intoexelearning:mainfrom
ateeducacion:feature/embedded-static-editor

Conversation

@erseco
Copy link
Collaborator

@erseco erseco commented Feb 9, 2026

This pull request introduces major improvements to the build, packaging, and deployment workflow for the mod_exeweb Moodle plugin, as well as enhancements to the embedded static editor integration. The most important changes include the addition of a release automation workflow, new Makefile targets for building and packaging the editor, submodule management for the embedded editor, and the implementation of a modal controller for the editor UI.

Build, Packaging, and Release Automation:

  • Added a GitHub Actions workflow (.github/workflows/release.yml) to automate building the static editor, packaging the plugin as a ZIP, and uploading it to GitHub Releases.
  • Introduced new Makefile targets for building the embedded static editor, managing the editor submodule, and packaging the plugin for distribution. The package target now updates the version in version.php, creates a ZIP archive, and restores the version.

Embedded Static Editor Integration:

  • Added a .gitmodules file to track the exelearning submodule, ensuring the editor source is managed and updated from a specific branch.
  • Created .distignore to exclude unnecessary files and directories from the distributable package, streamlining the ZIP archive.

Frontend Enhancements:

  • Implemented amd/src/editor_modal.js, a modal controller for the embedded eXeLearning editor. This provides a fullscreen overlay, handles save/close actions, and manages communication with the editor iframe.
  • Improved modform UI logic to correctly update button labels when the 'embedded' editor option is selected.

@erseco erseco self-assigned this Feb 9, 2026
@erseco erseco added the enhancement New feature or request label Feb 9, 2026
@pabloamayab
Copy link
Collaborator

pabloamayab commented Feb 19, 2026

Hi @erseco Great idea and work!!!

Here are my review (Moodle 5.0.4).
1.- Installation on the existing modexe_web plugin is correct.
2.- The plugin allows you to choose between static and online, which is correct.
3.- When I select online, everything is OK.
4.- When I select static, the edit button with eXeLearning does not appear. I have tried incognito mode, changing the resource integration method, etc., but it never appears. For this reason, I have not been able to test the static editor.

Do I need to run make build-editor in the plugin server folder to install eXe?

For now, I can't run make on the server, but as soon as I have it ready, I'll test it.

@erseco erseco marked this pull request as ready for review February 19, 2026 11:55
@pabloamayab
Copy link
Collaborator

OK @erseco
I was able to install it through the release. I previously downloaded the code directly from the branch, which was my mistake. Thank you for updating the readme.

The tests from my previous comment are now all OK.

I have detected the following problems:

  • Tiny throws errors in the console.
image - The image optimizer does not finish estimating the optimization time and therefore does not allow me to optimize images. - Close button. It closes eXe even if you are editing iDevices and you lose all your changes as it does not warn you of the possible loss of data. - Saving in Moodle throws a warning in the console and never finishes saving. image

That's it for now :-)

@pabloamayab
Copy link
Collaborator

Important:

  • Once Tiny has an image, the resource is no longer saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants