SED-4530 java-25-support-for-step

[david-stephan]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @david-stephan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential dependency updates to ensure compatibility and prepare the project for Java 25 support, as indicated by the associated ticket. The primary changes involve a significant upgrade of the Groovy programming language library and a necessary adjustment to its Maven group identifier. These updates are crucial for maintaining a modern and stable build environment.

Highlights

• Groovy Version Upgrade: Upgraded the Groovy dependency from version 3.0.23 to 5.0.4 across the project.
• Groovy Maven Group ID Migration: Migrated the Maven groupId for Groovy dependencies from org.codehaus.groovy to org.apache.groovy to reflect its current maintainer.
• Jacoco Plugin Update: Updated the Jacoco Maven plugin version from 0.8.12 to 0.8.14.
• Internal Dependencies Version: Updated the internal dependencies.version property to 0.0.0-SED-4530-SNAPSHOT, linking to the associated ticket.

Changelog

• pom.xml
  • Updated the dependencies.version property to 0.0.0-SED-4530-SNAPSHOT.
  • Upgraded the dep.groovy.version property to 5.0.4.
  • Updated the dep.mvn.jacoco.version property to 0.8.14.
  • Changed the groupId for groovy-bom and groovy-all dependencies from org.codehaus.groovy to org.apache.groovy.
• step-controller/step-controller-server/pom.xml
  • Changed the groupId for groovy-all and groovy-dateutil dependencies from org.codehaus.groovy to org.apache.groovy.
• step-core/pom.xml
  • Changed the groupId for groovy-all and groovy-dateutil dependencies from org.codehaus.groovy to org.apache.groovy.
• step-functions-plugins/step-functions-plugins-java/step-functions-plugins-java-def/pom.xml
  • Changed the groupId for groovy-all and groovy-dateutil dependencies from org.codehaus.groovy to org.apache.groovy.
• step-functions-plugins/step-functions-plugins-java/step-functions-plugins-java-handler/pom.xml
  • Changed the groupId for groovy-all and groovy-dateutil dependencies from org.codehaus.groovy to org.apache.groovy.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily focuses on dependency updates to support newer Java versions, including a major upgrade of Groovy and updates to the Jacoco plugin. The changes consistently update the Groovy groupId across various pom.xml files. My review highlights concerns about the use of what appear to be non-standard or pre-release versions for Groovy and Jacoco, which could pose risks to stability and maintainability.

[cl-exense]

Looks good to me, but you said you don't want to merge it anyway ;)