Skip to content

Added erlang ast test in captains-log #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiegillet merged 8 commits into from
Feb 28, 2026
Merged

Added erlang ast test in captains-log #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d1eb56
added erlang ast test in captains-log
FraSanga Sep 16, 2025
1a5b135
crlf to lf (end of line)
FraSanga Sep 27, 2025
ff21ba6
fix indent
FraSanga Sep 27, 2025
7d03355
reverted test_data changes
FraSanga Feb 24, 2026
ec514f7
fixed erlang & io_lib tests
FraSanga Feb 24, 2026
aecd996
fix CI build
FraSanga Feb 24, 2026
a9a7ae2
removed io_lib comment
FraSanga Feb 28, 2026
9d63733
fix typo
jiegillet Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir_analyzer/constants.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ defmodule ElixirAnalyzer.Constants do
captains_log_do_not_use_enum_random: "elixir.captains-log.do_not_use_enum_random",
captains_log_do_not_use_rand_uniform_real: "elixir.captains-log.do_not_use_rand_uniform_real",
captains_log_use_rand_uniform: "elixir.captains-log.use_rand_uniform",
captains_log_use_io_lib: "elixir.captains-log.use_io_lib",
captains_log_use_erlang: "elixir.captains-log.use_erlang",
Copy link
Contributor

@jiegillet jiegillet Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is a path to a file in this repo that contains the text of the analyzer comment, so you need to create a new file over there for the analyzer to work. Could you do the appropriate change over there, link to the PR in this PR's description and request a review from me?

Copy link
Contributor Author

@FraSanga FraSanga Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exercism/website-copy#2395

I cannot ask anyone for a review on the repo.


# Community Garden Comments
community_garden_use_get_and_update: "elixir.community-garden.use_get_and_update",
Expand Down
11 changes: 10 additions & 1 deletion lib/elixir_analyzer/test_suite/captains_log.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ defmodule ElixirAnalyzer.TestSuite.CaptainsLog do
type :essential
calling_fn module: CaptainsLog, name: :format_stardate
called_fn module: :io_lib, name: :_
comment Constants.captains_log_use_io_lib()
comment Constants.captains_log_use_erlang()
suppress_if "format_stardate uses :erlang", :pass
end

assert_call "format_stardate uses :erlang" do
type :essential
calling_fn module: CaptainsLog, name: :format_stardate
called_fn module: :erlang, name: :_
comment Constants.captains_log_use_erlang()
suppress_if "format_stardate uses :io_lib", :pass
end
end
36 changes: 28 additions & 8 deletions test/elixir_analyzer/test_suite/captains_log_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,34 @@ defmodule ElixirAnalyzer.ExerciseTest.CaptainsLogTest do
end
end

test_exercise_analysis "format_stardate uses Float.round",
comments_include: [Constants.captains_log_use_io_lib()] do
defmodule CaptainsLog do
def format_stardate(stardate) do
if is_float(stardate) do
Float.round(stardate, 1) |> to_string()
else
raise ArgumentError
describe "format_stardate uses :io_lib or :erlang" do
test_exercise_analysis "format_stardate uses Float.round",
comments_include: [Constants.captains_log_use_erlang()] do
defmodule CaptainsLog do
def format_stardate(stardate) do
if is_float(stardate) do
Float.round(stardate, 1) |> to_string()
else
raise ArgumentError
end
end
end
end

test_exercise_analysis "format_stardate uses :io_lib",
comments_exclude: [Constants.captains_log_use_erlang()] do
defmodule CaptainsLog do
def format_stardate(stardate) do
to_string(:io_lib.format("~.1f", [stardate]))
end
end
end

test_exercise_analysis "format_stardate uses :erlang",
comments_exclude: [Constants.captains_log_use_erlang()] do
defmodule CaptainsLog do
def format_stardate(stardate) do
:erlang.float_to_binary(stardate, [{:decimals, 1}])
end
end
end
Expand Down