protein-translation: Add tests for invalid sequences#1107
Open
mhorod wants to merge 1 commit intoexercism:mainfrom
Open
protein-translation: Add tests for invalid sequences#1107mhorod wants to merge 1 commit intoexercism:mainfrom
mhorod wants to merge 1 commit intoexercism:mainfrom
Conversation
petertseng
reviewed
Sep 6, 2022
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
hmm, there wasn't discussion in #630 of why these weren't added, but that must just be because they didn't exist in https://github.com/exercism/problem-specifications/blob/main/exercises/protein-translation/canonical-data.json then. but now that some tests do, we should better use those instead of making up our own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result type of the
proteinsfunction isMaybe [String]but all tests expectJust.I added some tests that expect
Nothingon an invalid input.