You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces 11 new tests for the sfg-parsing exercise to align it with the problem-specification repository.
However, I encountered difficulties with getting the example solution to work, despite spending several hours trying different approaches. Please let me know how you would like me to proceed from here.
Hey @jagdish-15, I managed to get something working. If I'm not mistaken, I think there is are too many \ characters in the withinPropertyValueWhitespace test (I think this is the "within property values, whitespace characters such as tab are converted to spaces" test case from the problem spec?). I couldn't quite see what you tried with the example solution, but if needed, I got something working by adding some more state to track while parsing.
Thank you so much, @kahgoh, for guiding me through this! I apologize for the oversight—there must have been a mistake on my part while copying data from the problem specification repository. I likely copied it directly from the terminal when the configlet printed the tests before updating, and some discrepancy must have occurred during that process. That aside, I’m happy to report that all tests are now passing after your changes to the reference solution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Hello @kahgoh,
This PR introduces 11 new tests for the
sfg-parsingexercise to align it with theproblem-specificationrepository.However, I encountered difficulties with getting the example solution to work, despite spending several hours trying different approaches. Please let me know how you would like me to proceed from here.
Reviewer Resources:
Track Policies