Passio Practice Exercise implemented by shreyasgosavi · Pull Request #2970 · exercism/java

shreyasgosavi · 2025-07-05T05:07:55Z

pull request

Hello, raising PR for paasio exercise implementation. Issue ID : #1813

Reviewer Resources:

Track Policies

…required files from the resources template to the exercise

… covered | Sample Implementation for some of the read methods is done

…mentation in FileOperations

kahgoh · 2025-07-09T12:33:00Z

exercises/practice/paasio/src/main/java/Paasio.java

This file should just contain enough of the stub for students to start. Have a look at the stub for the Poker for example. It only contains the bare methods for students to fill.

When the student starts the Paasio exercise, the student will start with the contents of this file. They should not start with the solution.

kahgoh · 2025-07-09T12:35:56Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+    void checkReadOperationCount() {
+
+        try (Paasio customFileReader = new Paasio(this.dataInputStream, this.dataOutputStream)) {
+            customFileReader.read();
+            customFileReader.read();
+            customFileReader.read();
+            assertThat(customFileReader.getReadOperationCount()).isEqualTo(3);
+        } catch (IOException ioException) {
+            System.out.println("Exception occured");
+        }
+
+    }


Don't catch the exception in the tests, othewise the tests will pass if an exception is thrown. Instead, let propagate the exception so that JUnit also sees the exception.

Suggested change

void checkReadOperationCount() {

try (Paasio customFileReader = new Paasio(this.dataInputStream, this.dataOutputStream)) {

customFileReader.read();

customFileReader.read();

customFileReader.read();

assertThat(customFileReader.getReadOperationCount()).isEqualTo(3);

} catch (IOException ioException) {

System.out.println("Exception occured");

}

}

void checkReadOperationCount() throw Exception {

try (Paasio customFileReader = new Paasio(this.dataInputStream, this.dataOutputStream)) {

customFileReader.read();

customFileReader.read();

customFileReader.read();

assertThat(customFileReader.getReadOperationCount()).isEqualTo(3);

}

}

kahgoh · 2025-07-09T12:37:44Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+import org.junit.jupiter.api.*;
+
+import java.io.*;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+
+import static org.assertj.core.api.Assertions.*;


Please don't use * imports, as per other tests (poker for example).

kahgoh · 2025-07-09T12:40:57Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+
+            byte[] readByteData = new byte[5];
+            fileOperations.read(readByteData);
+            assertThat(fileOperations.getBytesRead()).isEqualTo(9);


I think it would be interesting to assert on the contents readByteData.

kahgoh · 2025-07-09T12:42:42Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+
+    }
+
+    @Test


In general, only the first test should be "enabled" in practice exercises. Students enable the test as they work through the exercise.

Suggested change

@Test

@Disabled("Remove to run test")

@Test

kahgoh · 2025-07-09T12:44:54Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+            System.out.println("haha ");
+            System.out.println(fileOperations.getReadOperationCount());


Please remove all System.out.println.

Suggested change

System.out.println("haha ");

System.out.println(fileOperations.getReadOperationCount());

System.out.println("haha ");

System.out.println(fileOperations.getReadOperationCount());

kahgoh · 2025-07-09T12:48:52Z

config.json

+        "uuid": "81177978-2ed3-47c2-a6a0-fef316d94c0b",
+        "practices": [],
+        "prerequisites": [],
+        "difficulty": 1


This really shouldn't be a one (it's not that easy). Perhaps we could use the Go track as a guide - they have used 4 as the difficulty.

kahgoh · 2025-07-09T12:49:24Z

exercises/practice/paasio/.meta/src/reference/java/Paasio.java

@@ -0,0 +1,140 @@
+import java.io.*;


Please don't use * imports. For example:

Suggested change

import java.io.*;

import java.io.Closeable;

import java.io.InputStream;

import java.io.OutputStream;

kahgoh · 2025-07-09T12:54:33Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+public class PaasioTest {
+
+    private ByteArrayInputStream dataInputStream;
+    private ByteArrayOutputStream dataOutputStream;


Since every test creates and uses a Paasio object, we could also use a Passio field and set it in setUpTest and then close it after every test in a @AfterEach method.

kahgoh · 2025-07-09T12:54:41Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+    private static final String MESSAGECONSTANT = "This is additional Content.";
+
+    @BeforeEach
+    public void setUPTest(TestInfo testInfo) {


Suggested change

public void setUPTest(TestInfo testInfo) {

public void setUpTest(TestInfo testInfo) {

shreyasgosavi · 2025-07-12T09:57:07Z

Thanks for time and that's really good explanation will do it 🤘

shreyasgosavi · 2025-08-05T19:59:03Z

Heyyy I have made the requested changes could you please verify that

jagdish-15 · 2025-08-06T11:08:14Z

exercises/practice/paasio/src/main/java/Paasio.java

@@ -0,0 +1,98 @@
+import java.io.*;


As mentioned earlier, please don't use * for import

jagdish-15 · 2025-08-06T11:08:44Z

exercises/practice/paasio/.meta/src/reference/java/Paasio.java

@@ -0,0 +1,149 @@
+import java.io.*;


Same goes for this!

jagdish-15 · 2025-08-06T11:10:57Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        assertThat(paasioReaderWriter.getBytesRead()).isEqualTo(4);
+    }
+
+    @Test


Every test except the first one should have @Disabled("Remove to run test")

jagdish-15 · 2025-08-06T11:13:47Z

config.json

        ],
        "difficulty": 10
+      },
+      {


Could you please move this exercise up with the other ones that have a difficulty of 4, and make sure it stays in alphabetical order within that section?

kahgoh · 2025-08-06T13:46:40Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        if (!Objects.isNull(this.paasioReaderWriter.getInputStream())) {
+            this.paasioReaderWriter.getInputStream().close();
+        }
+        if (!Objects.isNull(this.paasioReaderWriter.getOutputStream())) {
+            this.paasioReaderWriter.getOutputStream().close();
+        }


I think this could be simplified to simply calling passioReaderWriter.close() and might allow you to remove getInputStream and getOutputStream methods from the Passio class.

kahgoh · 2025-08-06T13:48:43Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+
+

There seems to be extra spacing here.

Suggested change

kahgoh · 2025-08-06T13:52:45Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        byte[] initialMessage = "Hello! ".getBytes();
+        byte[] messageArray = Arrays.copyOf(initialMessage, 50);
+
+        int length = messageArray.length - initialMessage.length - 2;


I wasn't sure - why do we need to subtract 2 here?

kahgoh · 2025-08-06T14:02:47Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+    @Disabled("Remove to run test")
+    void checkByteValueReadFromTheFile() throws IOException {
+
+        byte[] fileData = new byte[100];


I think this fileData name came from an earlier iteration where we had a distinction between file and network data. However, we no longer have this distinction, so I'd suggest renaming it. Perhaps just data?

kahgoh · 2025-08-06T14:22:05Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        byte[] dataRead = Arrays.copyOf(helloArray, 100);
+
+        int bytesRead = paasioReaderWriter.read(dataRead, helloArray.length, 40);
+        String finalVAlue = new String(dataRead, 0, helloArray.length + bytesRead, StandardCharsets.UTF_8);


Suggested change

String finalVAlue = new String(dataRead, 0, helloArray.length + bytesRead, StandardCharsets.UTF_8);

String finalValue = new String(dataRead, 0, helloArray.length + bytesRead, StandardCharsets.UTF_8);

kahgoh · 2025-08-06T14:25:25Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        byte[] byteData = new byte[50];
+        int bytesRead = paasioReaderWriter.read(byteData, 0, 10);
+
+        assertThat(bytesRead).isEqualTo(10);


I think we should also assert the contents byteData as it should write only 10 bytes to the array. This should be less than the available content?

Should there also be a test for when the length (or the "10") is more than what is available?

kahgoh · 2025-08-06T14:27:25Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+    void validateReadNBytesReadOperationCount() throws IOException {
+
+        paasioReaderWriter.readNBytes(5);
+        paasioReaderWriter.readNBytes(5);


I think we are also missing tests that assert on the byte[] that is returned by the readNBytes method.

kahgoh · 2025-08-06T14:36:36Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+
+    private ByteArrayInputStream dataInputStream;
+    private ByteArrayOutputStream dataOutputStream;
+    private static final String MESSAGECONSTANT = "This is additional Content.";


It is more idiomatic to use screaming snake case for constants in Java. Could you please also move this to just under the public class PaasioTest { line? (its more idiomatic that way)

Suggested change

private static final String MESSAGECONSTANT = "This is additional Content.";

private static final String MESSAGE_CONSTANT = "This is additional Content.";

kahgoh · 2025-08-06T14:38:43Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+        paasioReaderWriter.write(writeFileContent);
+        paasioReaderWriter.write(writeFileContent);
+        paasioReaderWriter.write('s');
+


I think this is missing asserting on the contents that are written to the dataOutputStream.

kahgoh · 2025-08-06T14:39:28Z

exercises/practice/paasio/src/test/java/PaasioTest.java

+    @Disabled("Remove to run test")
+    void verifyBytesWrittenFromOffsetIntoTheOutputStreamAlongWithTheCount() throws IOException {
+
+        String fileContentToBeWritten = "   This is additional Content.";


Similar to another comment, this isn't "file" specific, so suggest renaming the variable.

shreyasgosavi added 19 commits May 23, 2025 16:02

Setting up paasio exercise | Added paasio in settings.gradle | Added …

a912d0c

…required files from the resources template to the exercise

Added Sample code to avoid Build failure

d81eb05

Paasio Code begins | Started Code structure set-up

bc2a2cd

Developing with TDD strategy | Test-cases for file-reading operations…

c83978c

… covered | Sample Implementation for some of the read methods is done

Test cases for Write Operations for file handling written

52e1794

Sample Code added for File-Operations

3507f1c

FileOperation Changes added

4a94e3c

Adding Generic Input-Output Operation class | Referring to that imple…

d1d9917

…mentation in FileOperations

Adding tags to the File Operation Test Cases

4c67d9b

Test Cases for SOcket Opearations added. along with its implementations

9706a9f

Another test case to verify data written in output-stream

8c3aaf5

Changed the implementation to more generic code.

0aeb078

Code formatted

71e0867

Un-necessary test-cases consolidated and shortened

b934489

Merge branch 'paasio-exercise'

b8ba510

Sonar Qube changes added | Changes in test cases -- corrected arguments

e07be74

Merge branch 'paasio-exercise'

03ee525

Changes synced with reference code

47ef869

Code formatted

fbf5c8d

shreyasgosavi marked this pull request as draft July 5, 2025 05:17

kahgoh changed the title ~~Passi Practice Exercise implemented~~ Passio Practice Exercise implemented Jul 5, 2025

kahgoh requested changes Jul 9, 2025

View reviewed changes

shreyasgosavi and others added 2 commits August 6, 2025 01:16

Changes suggested by kahgoh were made

3e71a5b

Merge branch 'exercism:main' into main

251ef7e

shreyasgosavi marked this pull request as ready for review August 5, 2025 19:58

jagdish-15 requested changes Aug 6, 2025

View reviewed changes

kahgoh reviewed Aug 6, 2025

View reviewed changes

		System.out.println("haha ");
		System.out.println(fileOperations.getReadOperationCount());

-import java.io.*;
+import java.io.Closeable;
+import java.io.InputStream;
+import java.io.OutputStream;

	public void setUPTest(TestInfo testInfo) {
	public void setUpTest(TestInfo testInfo) {

	String finalVAlue = new String(dataRead, 0, helloArray.length + bytesRead, StandardCharsets.UTF_8);
	String finalValue = new String(dataRead, 0, helloArray.length + bytesRead, StandardCharsets.UTF_8);

	private static final String MESSAGECONSTANT = "This is additional Content.";
	private static final String MESSAGE_CONSTANT = "This is additional Content.";

Uh oh!

Conversation

shreyasgosavi commented Jul 5, 2025

pull request

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shreyasgosavi commented Jul 12, 2025

Uh oh!

shreyasgosavi commented Aug 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants