MatrixTest, LuhnValidatorTest, PangramCheckerTest#3018
MatrixTest, LuhnValidatorTest, PangramCheckerTest#3018jagdish-15 merged 6 commits intoexercism:mainfrom Aditya5009:java_test
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
jagdish-15
left a comment
jagdish-15
left a comment
There was a problem hiding this comment.
I noticed you added an extra * before Character.getNumericValue() in the comment. Could you please revert that back to the original
| /* The following test diverges from the canonical test data. This is because the corresponding canonical test does | ||
| * not account for Java specific functions (such as Character.getNumericValue()), which can be part of incorrect yet | ||
| * not account for Java specific functions (such as * Character.getNumericValue()), which can be part of incorrect yet | ||
| * passing implementations. For more detail, check out issue #972 here: | ||
| * (https://github.com/exercism/java/issues/972). | ||
| */ |
There was a problem hiding this comment.
| /* The following test diverges from the canonical test data. This is because the corresponding canonical test does | |
| * not account for Java specific functions (such as Character.getNumericValue()), which can be part of incorrect yet | |
| * not account for Java specific functions (such as * Character.getNumericValue()), which can be part of incorrect yet | |
| * passing implementations. For more detail, check out issue #972 here: | |
| * (https://github.com/exercism/java/issues/972). | |
| */ | |
| /* The following test diverges from the canonical test data. This is because the corresponding canonical test does | |
| * not account for Java specific functions (such as Character.getNumericValue()), which can be part of incorrect yet | |
| * passing implementations. For more detail, check out issue #972 here: | |
| * (https://github.com/exercism/java/issues/972). | |
| */ |
There was a problem hiding this comment.
Also, could you add this @DisplayName("string containing symbols is invalid (Java track specific)") tag to the last test (since it’s Java-specific, you wouldn’t have found one for it in the problem-specifications repo), and slightly adjust the method name to testStringContainingSymbolsIsInvalidJavaTrackSpecific()?
There was a problem hiding this comment.
Hey, I’ve reverted as requested. Please check and confirm. I must have added that * accidentally, sorry for the inconvenience.
There was a problem hiding this comment.
Could you also add the last DisplayName tag for the Java-specific test? I've provided the information above.
There was a problem hiding this comment.
Thank you for your guidance and for accepting my changes. This was my first contribution to an open-source project, and I really appreciate the support.
There was a problem hiding this comment.
You’re very welcome! Thanks for making your first contribution here. It’s always great to see new contributors getting involved. Congrats on your first PR, and we hope to see more from you in the future!
* MatrixTest, LuhnValidatorTest, PangramCheckerTest * change * MatrixTest, LuhnValidatorTest, PangramCheckerTest * MatrixTest, LuhnValidatorTest, PangramCheckerTest * MatrixTest, LuhnValidatorTest, PangramCheckerTest [no important files changed]
2 participants
pull request
Hello, I am new to open source contribution. This is my first contribution.
I have gone through README, Code of conduct, and Contributing.
Added @DisplayName() annotation in MatrixTest, LuhnValidatorTest, PangramCheckerTest.
Passed all test cases, checks, and compileStarterTestJava.
Reviewer Resources:
Track Policies