remove use std::ascii::AsciiExt for Rust 1.23#411
Merged
petertseng merged 1 commit intoexercism:masterfrom Jan 15, 2018
petertseng:asciiext
Merged
remove use std::ascii::AsciiExt for Rust 1.23#411petertseng merged 1 commit intoexercism:masterfrom petertseng:asciiext
use std::ascii::AsciiExt for Rust 1.23#411petertseng merged 1 commit intoexercism:masterfrom
petertseng:asciiext
Conversation
Member
Author
|
Well, I guess I kind of saw it coming. It doesn't compile on 1.22 but apparently will on 1.23. So when 1.23 becomes stable, since we disallow warnings on stable, our build will break until merging this PR. Okay, well, we can't merge it until that time, so we shouldn't leave it open. In the meantime, let's hunt for the change that made this happen. |
Member
Author
|
It's still the case that you must import a trait to use its methods (I was worried for a moment there), just that there are new inherent methods. |
Member
Author
|
It's time. |
In rust 1.23, the `AsciiExt` methods are implemented directly on the concerned types, so attempting to import `AsciiExt` results in an unused import. Rust language PR: rust-lang/rust#44042 PSA: https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726 This started warning as an unused import on nightly sometime between 2017-11-02 and 2017-11-09: https://travis-ci.org/exercism/rust/builds/296391447 https://travis-ci.org/exercism/rust/builds/299770403 This started warning on beta exactly when 1.23.0 became Beta (it was accepted on 1.22.0): https://travis-ci.org/exercism/rust/builds/303139434 https://travis-ci.org/exercism/rust/builds/306431846 As 1.23 is now stable and our repo disallows warnings on stable, we will need this.
Member
|
Agreed. These changes look good to me. |
Member
Author
|
I rewrote the commit message but made no other changes. |
petertseng
changed the title
use std::ascii::AsciiExtuse std::ascii::AsciiExt for Rust 1.23
coriolinus
approved these changes
Jan 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove
use std::ascii::AsciiExtfor rust 1.23In rust 1.23, the
AsciiExtmethods are implemented directly on theconcerned types, so attempting to import
AsciiExtresults in anunused import.
Rust language PR:
rust-lang/rust#44042
PSA:
https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726
This started warning as an unused import on nightly sometime between
2017-11-02 and 2017-11-09:
https://travis-ci.org/exercism/rust/builds/296391447
https://travis-ci.org/exercism/rust/builds/299770403
This started warning on beta exactly when 1.23.0 became Beta (it was
accepted on 1.22.0):
https://travis-ci.org/exercism/rust/builds/303139434
https://travis-ci.org/exercism/rust/builds/306431846
As 1.23 is now stable and our repo disallows warnings on stable, we will
need this.